Skip to content

Using assertSame to assert expected strictly#57

Merged
g105b merged 1 commit intophpgt:masterfrom
peter279k:improve_assertions
May 10, 2021
Merged

Using assertSame to assert expected strictly#57
g105b merged 1 commit intophpgt:masterfrom
peter279k:improve_assertions

Conversation

@peter279k
Copy link
Copy Markdown
Contributor

Changed log

As title, and fixing following issue:

PHPUnit 8.5.3 by Sebastian Bergmann and contributors.

F...........                                                      12 / 12 (100%)

Time: 39 ms, Memory: 4.00 MB

There was 1 failure:

1) Gt\ProtectedGlobal\Test\ProtectedGlobalTest::testToString
Failed asserting that Gt\ProtectedGlobal\ProtectedGlobal Object &0000000045514ba4000000000c9e6e7f (
    'whiteListData' => Array &0 ()
) is identical to 'Global variables are protected - see https://php.gt/globals'.

/data/ProtectedGlobal/test/unit/ProtectedGlobalTest.php:12

FAILURES!
Tests: 12, Assertions: 20, Failures: 1.

@g105b g105b merged commit 32e4dfd into phpgt:master May 10, 2021
@g105b
Copy link
Copy Markdown
Member

g105b commented May 10, 2021

Thank you.

@peter279k peter279k deleted the improve_assertions branch May 10, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants