New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie “phpMyAdmin” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute. #16981
Comments
Should be fixed by this diff diff --git a/libraries/classes/Session.php b/libraries/classes/Session.php
index f68bad2495..3d1290d881 100644
--- a/libraries/classes/Session.php
+++ b/libraries/classes/Session.php
@@ -180,6 +180,8 @@ class Session
ini_set('session.use_strict_mode', '1');
// make the session cookie HttpOnly
ini_set('session.cookie_httponly', '1');
+ // add SameSite to the session cookie
+ ini_set('session.cookie_samesite', $config->get('CookieSameSite'));
// do not force transparent session ids
ini_set('session.use_trans_sid', '0');https://www.php.net/manual/en/session.configuration.php#ini.session.cookie-samesite (Available as of PHP 7.3.0.) |
|
Related to #16316. |
|
We have to make sure that it will work with PHP prior to version 7.3.0. |
I am not sure to understand what you mean, but for sure we will need to restrict the usage to PHP >= 7.3 by an if |
That is what I meant. |
Signed-off-by: William Desportes <williamdes@wdes.fr>
…rted by Psalm Signed-off-by: William Desportes <williamdes@wdes.fr>
- Related to phpmyadmin#16981 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Describe the bug
Server configuration
Client configuration
The text was updated successfully, but these errors were encountered: