Skip to content

[Toon Export] Fix null separator#20082

Merged
williamdes merged 1 commit intophpmyadmin:masterfrom
faissaloux:fix/toon-null-separator
Feb 7, 2026
Merged

[Toon Export] Fix null separator#20082
williamdes merged 1 commit intophpmyadmin:masterfrom
faissaloux:fix/toon-null-separator

Conversation

@faissaloux
Copy link
Copy Markdown
Contributor

No description provided.

@faissaloux faissaloux mentioned this pull request Feb 6, 2026
@williamdes
Copy link
Copy Markdown
Member

Would you mind fixing lint?
please use git commit --amend
And a force push

Signed-off-by: faissaloux <fwahabali@gmail.com>
@faissaloux faissaloux force-pushed the fix/toon-null-separator branch from bf272ca to 0817747 Compare February 6, 2026 23:00
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.50%. Comparing base (852f1b5) to head (0817747).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20082   +/-   ##
=========================================
  Coverage     63.50%   63.50%           
+ Complexity    16045    16044    -1     
=========================================
  Files           679      679           
  Lines         59911    59908    -3     
=========================================
+ Hits          38046    38047    +1     
+ Misses        21865    21861    -4     
Flag Coverage Δ
unit-8.2-ubuntu-latest ?
unit-8.3-ubuntu-latest 63.50% <100.00%> (+0.04%) ⬆️
unit-8.4-ubuntu-latest 63.44% <100.00%> (-0.06%) ⬇️
unit-8.5-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@faissaloux
Copy link
Copy Markdown
Contributor Author

@williamdes done!

Copy link
Copy Markdown
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome
Would you like helping me with https://github.com/wdes/contrib-merge/
This is the tool used to merge PRs
Since the ChangeLog format changed it's --changelog option is now working
Brilliant ideas to make it easier or automatic are welcome

No obligations, any help on this tool gets phpMyAdmin better PR management (at least for me)

@williamdes williamdes merged commit e76adf1 into phpmyadmin:master Feb 7, 2026
44 checks passed
@faissaloux faissaloux deleted the fix/toon-null-separator branch February 7, 2026 12:50
@faissaloux
Copy link
Copy Markdown
Contributor Author

Would you like helping me with https://github.com/wdes/contrib-merge/

Sure! I'll be happy to.

@williamdes williamdes self-assigned this Feb 7, 2026
@williamdes williamdes added this to the 6.0.0 milestone Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants