Skip to content

Fix default functions in InsertEdit#20108

Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
kamil-tekiela:Fix-default-functions-in-InsertEdit
Feb 16, 2026
Merged

Fix default functions in InsertEdit#20108
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
kamil-tekiela:Fix-default-functions-in-InsertEdit

Conversation

@kamil-tekiela
Copy link
Contributor

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Feb 15, 2026

Now works, except if I have DefaultFunctions. Not sure how DefaultFunctions is supposed to work here. From my understanding, everything is by default, except if I change it here, it will take value from config.

LE: In 5.2.4-dev works.

OK:

$cfg['DefaultFunctions'] = [
    'FUNC_SPATIAL' => 'ST_GeomFromText',
];

NOT OK:

$cfg['DefaultFunctions'] = [
    'first_timestamp' => '',
];
15.02.2026_19.18.06_REC.mp4

@kamil-tekiela
Copy link
Contributor Author

I'm not sure either. This needs some more investigation. Was it working fine before #19857?

@liviuconcioiu
Copy link
Contributor

I see it working in 5.2.4-dev

@liviuconcioiu
Copy link
Contributor

Yes, it was working before 19857

@kamil-tekiela
Copy link
Contributor Author

Now works, except if I have DefaultFunctions. Not sure how DefaultFunctions is supposed to work here. From my understanding, everything is by default, except if I change it here, it will take value from config.

LE: In 5.2.4-dev works.

OK:

$cfg['DefaultFunctions'] = [
    'FUNC_SPATIAL' => 'ST_GeomFromText',
];

NOT OK:

$cfg['DefaultFunctions'] = [
    'first_timestamp' => '',
];

15.02.2026_19.18.06_REC.mp4

Found it. That's something different, though. I am going to treat it separately.

@MauricioFauth MauricioFauth merged commit 0a5032d into phpmyadmin:master Feb 16, 2026
61 of 63 checks passed
@MauricioFauth MauricioFauth self-assigned this Feb 16, 2026
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Feb 16, 2026
@kamil-tekiela kamil-tekiela deleted the Fix-default-functions-in-InsertEdit branch February 16, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.0]: Geometry no longer shows

3 participants