Fix issue with parsing TRUNCATE statements, Issue #221 #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
============================================
- Coverage 99.7% 99.65% -0.05%
- Complexity 1841 1843 +2
============================================
Files 61 62 +1
Lines 4088 4091 +3
============================================
+ Hits 4076 4077 +1
- Misses 12 14 +2 |
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 99.58% 99.65% +0.06%
+ Complexity 1856 1843 -13
============================================
Files 62 62
Lines 4127 4091 -36
============================================
- Hits 4110 4077 -33
+ Misses 17 14 -3 |
|
Wonder why conflicts came out. |
|
Merged the latest master branch to resolve conflicts. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ibennetch
left a comment
ibennetch
left a comment
There was a problem hiding this comment.
@devenbansod would you have a moment to take a quick look and see if this seems suitable to you?
It looks great to me aside from the possible debugging function I mentioned.
src/Token.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Make you happier when you need to debug. |
There was a problem hiding this comment.
Is this function valuable to include in the code or is it debugging code that should be removed?
If it's worth keeping, I think the comment here should be changed to make the purpose of the function more clear.
ibennetch
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Fixes: phpmyadmin#221 Pull-request: phpmyadmin#222 Co-authored-by: Sinri Edogawa <e.joshua.s.e@gmail.com> Signed-off-by: William Desportes <williamdes@wdes.fr>
Pull-request: #222 Signed-off-by: William Desportes <williamdes@wdes.fr>
|
Great Result Finally! |
3 participants
Make the following SQL parsable, which is mentioned in issue #221
truncate tablea.b;truncate c;select truncate from truncate;