Skip to content

Conversation

@ibennetch
Copy link
Member

Signed-off-by: Isaac Bennetch bennetch@gmail.com

@devenbansod devenbansod self-requested a review April 28, 2019 06:28
@devenbansod
Copy link
Member

@ibennetch it seems we need to adjust the tests for CLI.php

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #243 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
+ Coverage     99.63%   99.63%   +<.01%     
  Complexity     1849     1849              
============================================
  Files            61       61              
  Lines          4118     4121       +3     
============================================
+ Hits           4103     4106       +3     
  Misses           15       15

@ibennetch
Copy link
Member Author

Thanks, that should be fixed now.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ibennetch ibennetch merged commit d9ef8ae into phpmyadmin:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants