Stop instanciating an object to check its class name.#290
Merged
williamdes merged 1 commit intophpmyadmin:QAfrom Feb 9, 2020
Merged
Stop instanciating an object to check its class name.#290williamdes merged 1 commit intophpmyadmin:QAfrom
williamdes merged 1 commit intophpmyadmin:QAfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## QA #290 +/- ##
=====================================
Coverage 100% 100%
+ Complexity 1865 1864 -1
=====================================
Files 63 63
Lines 4527 4527
=====================================
Hits 4527 4527 |
williamdes
reviewed
Feb 6, 2020
williamdes
approved these changes
Feb 6, 2020
williamdes
added a commit
that referenced
this pull request
Feb 9, 2020
Pull-request: #290 Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes
added a commit
that referenced
this pull request
Feb 9, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
Member
|
Thank you @niconoe- for this fix ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246
When set on master, where PHP 5.3 is not maintained anymore, this could be a little bit improved.
I did not use
is_abecause of the function call (not good for performance) and I did not useinstanceofneither because$classis a string, not an object. We are actually comparing 2 strings, so let's just compare 2 strings...I'm aware it has not the exact same behavior in case of
$classis a string evaluated to a class name of a child ofFunctionCallclass, but it appears thatFunctionCallhas no children, so the misbehavior here is not applicable.