Skip to content

Added check for quoted symbol to avoid parser error in case of keyword #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
williamdes merged 1 commit into from
Nov 9, 2020
Merged

Added check for quoted symbol to avoid parser error in case of keyword #318

williamdes merged 1 commit into from
Nov 9, 2020

Conversation

@elliot2extreme
Copy link
Contributor

@elliot2extreme elliot2extreme commented Nov 2, 2020 •
edited by williamdes
Loading

Fixes #317

@elliot2extreme
Copy link
Contributor Author

elliot2extreme commented Nov 2, 2020

#317

williamdes
williamdes reviewed Nov 3, 2020
View reviewed changes
@williamdes williamdes added this to the 4.7.2 milestone Nov 3, 2020
@williamdes
Copy link
Member

williamdes commented Nov 3, 2020

You seem to have a misconfigured GIT Markus Buch <markus@macbook-pro-007.intern> by the way ;)
Good work on this issue

@elliot2extreme
Copy link
Contributor Author

elliot2extreme commented Nov 3, 2020

You seem to have a misconfigured GIT Markus Buch <markus@macbook-pro-007.intern> by the way ;)
Good work on this issue

Thanks for you hint, I forgot to change it.

@williamdes
Copy link
Member

williamdes commented Nov 3, 2020

You seem to have a misconfigured GIT Markus Buch <markus@macbook-pro-007.intern> by the way ;)
Good work on this issue

Thanks for you hint, I forgot to change it.

Feel free to squash and force push your commits if you want before this PR is merged :)
git rebase -i --exec 'git commit --amend --reset-author --no-edit' 550ce6968794e890cfd5b4cbf202e716d78b6a92

@elliot2extreme
Copy link
Contributor Author

elliot2extreme commented Nov 3, 2020 •
edited
Loading

Is there anything more I have to do for this pr? The Travis CI seems to be failing in one case because of a missing composer lock file. Thanks for your support.

@williamdes
Copy link
Member

williamdes commented Nov 4, 2020

Is there anything more I have to do for this pr? The Travis CI seems to be failing in one case because of a missing composer lock file. Thanks for your support.

"6398 Segmentation fault " never mind, I consider the build to be successful https://travis-ci.org/github/phpmyadmin/sql-parser/jobs/741093817#L539

devenbansod
devenbansod approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@devenbansod devenbansod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 💯

@williamdes williamdes self-assigned this Nov 9, 2020
@williamdes williamdes merged commit 192089d into phpmyadmin:QA Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes left review comments

@devenbansod devenbansod devenbansod approved these changes

Assignees

@williamdes williamdes

Labels

None yet

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@elliot2extreme @williamdes @devenbansod