Fix #330 - Add KEY to CreateDefinition

[williamdes]

Fixes: #330

[williamdes]

What do you think about this small change @iifawzi @Tithugues @niconoe- ?
Is this the right way to add it ?
KEY is already in contexts
And I added the test cases in 87f1dfa

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (87f1dfa) 97.04% compared to head (0d37022) 97.04%.

Additional details and impacted files

@@            Coverage Diff            @@
##              5.8.x     #441   +/-   ##
=========================================
  Coverage     97.04%   97.04%           
  Complexity     2218     2218           
=========================================
  Files            69       69           
  Lines          5107     5107           
=========================================
  Hits           4956     4956           
  Misses          151      151           

Impacted Files	Coverage Δ
src/Components/CreateDefinition.php	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Tithugues]

What do you think about this small change @iifawzi @Tithugues @niconoe- ? Is this the right way to add it ? KEY is already in contexts And I added the test cases in 87f1dfa

Yes, it seems to be OK. But as we add this option, I think we should try to support INDEX as well (see CREATE table definition).

[williamdes]

What do you think about this small change @iifawzi @Tithugues @niconoe- ? Is this the right way to add it ? KEY is already in contexts And I added the test cases in 87f1dfa

Yes, it seems to be OK. But as we add this option, I think we should try to support INDEX as well (see CREATE table definition).

Thank you !
I will make another PR, would you mind having a look to the two other ones I did ?

[williamdes]

Hi @Tithugues

I have tried to find out an example about INDEX but I think we already support that.
See: 52608cb

[Tithugues]

Hi @Tithugues

I have tried to find out an example about INDEX but I think we already support that. See: 52608cb

Sorry, I misread the MySQL documentation! There is no INDEX option to support. 🙏