Fix #450 - Parsing insert queries with functions trims commas #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing of a value must not stop when a comma is found.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #474 +/- ##
============================================
- Coverage 97.04% 97.02% -0.02%
- Complexity 2218 2234 +16
============================================
Files 69 69
Lines 5107 5144 +37
============================================
+ Hits 4956 4991 +35
- Misses 151 153 +2
☔ View full report in Codecov by Sentry. |
williamdes
changed the title
williamdes
added a commit
that referenced
this pull request
Jun 5, 2023
Pull-request: #474 Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing of a value must not stop when a comma is found.
Fixes: #450