Allow parsing KILL statement

[MoonE]

Fixes #556

[MoonE]

Could also use $CLAUSES to build it. Though it fails to build an invalid statement like KILL ; which may not matter.

diff --git a/src/Statements/KillStatement.php b/src/Statements/KillStatement.php
index 7040a0f3..4ef3f532 100644
--- a/src/Statements/KillStatement.php
+++ b/src/Statements/KillStatement.php
@@ -28,16 +28,22 @@ class KillStatement extends Statement
         'QUERY' => 1,
     ];
 
+    public static $CLAUSES = [
+        'KILL' => [
+            'KILL',
+            2,
+        ],
+        // Used for options.
+        '_OPTIONS' => [
+            '_OPTIONS',
+            1,
+        ],
+        'EXPRESSION' => [
+            'KILL',
+            1,
+        ],
+    ];
+
     /** @var Expression|null */
     public $processListId = null;
-
-    public function build(): string
-    {
-        $option = $this->options === null || $this->options->isEmpty()
-            ? ''
-            : ' ' . OptionsArray::build($this->options);
-        $expression = $this->processListId === null ? '' : ' ' . Expression::build($this->processListId);
-
-        return trim('KILL' . $option . $expression);
-    }
 }
diff --git a/tests/Parser/KillStatementTest.php b/tests/Parser/KillStatementTest.php
index 99b81f75..e3a1e4c8 100644
--- a/tests/Parser/KillStatementTest.php
+++ b/tests/Parser/KillStatementTest.php
@@ -53,7 +53,6 @@ class KillStatementTest extends TestCase
             ['KILL (SELECT 3 + 4)'],
             ['KILL QUERY 3'],
             ['KILL CONNECTION 3'],
-            ['KILL'],
         ];
     }
 }

[williamdes]

Looks good to me
@niconoe- or @iifawzi could you also review please ?

[niconoe-]

LGTM but I don’t know the KILL command 😅

[iifawzi]

Thanks for your hard work! it looks good to me, it would be awesome if we could just add the parsing logic

[iifawzi]

It would be awesome if we could extend support of Maria KILL options

[MoonE]

Oh yeah, makes sense.

[iifawzi]

I do believe we need some parsing logic here, so we can accurately validate the statement

[iifawzi]

is it a valid use case? why would someone need to kill a query or connection that way?

[MoonE]

The use case may be questionable, but the query is valid and working.

[iifawzi]

or maybe someone can utilize this by dynamically killing queries that are locking others? by selecting their IDs from the activity? if that's the case, maybe we can also parse the nested select statements? and delegate the building of these queries to their classes? ( most probably it's only SELECT statement that would be allowed ). what do you think?

[iifawzi]

This should be invalid, hence why the parsing logic is so important

[iifawzi]

I meant KILL is what expected to be invalid

[MoonE]

This is parsed with an error, I was unsure whether it should be able to build a query that was parsed with error. It is probably not needed.

[iifawzi]

It's been a while since I interacted with the parser, so I might be mistaken. How this's parsed with an error? if there's no parse function I don't think the statement would be even parsed or validated

[iifawzi]

I believe we need the parsing logic so we can throw an error if it's incorrect, the same as we did with the CREATE statement for example

[iifawzi]

I believe we should instead utilize var options instead of using custom option

    public static $OPTIONS = [
        'CONNECTION' => [
            1,
            'var',
        ],
        'QUERY' => [
            1,
            'var',
        ],
    ];