Skip to content

Add task for composer-require-checker#415

Merged
veewee merged 2 commits intophpro:masterfrom
jyggen:feature/composer-require-checker
Oct 27, 2017
Merged

Add task for composer-require-checker#415
veewee merged 2 commits intophpro:masterfrom
jyggen:feature/composer-require-checker

Conversation

@jyggen
Copy link
Contributor

@jyggen jyggen commented Oct 22, 2017

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets -

Adds support for composer-require-checker.

A CLI tool to analyze composer dependencies and verify that no unknown symbols are used in the sources of a package. This will prevent you from using "soft" dependencies that are not defined within your composer.json require section.

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@veewee veewee requested a review from Landerstraeten October 27, 2017 06:14
@veewee veewee added this to the Version 0.12.1 milestone Oct 27, 2017
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyggen, Thanks for the PR! Can you resolve the conflicts? The code looks good to me!

@jyggen
Copy link
Contributor Author

jyggen commented Oct 27, 2017

@veewee Done!

@veewee veewee merged commit 32d1bba into phpro:master Oct 27, 2017
@veewee
Copy link
Contributor

veewee commented Oct 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants