PHP 8.6 fixes - #673
Open
andypost wants to merge 2 commits into
Open
Conversation
neclimdul
reviewed
Jul 6, 2026
Comment on lines
48
to
60
| $node->addProperty('objectProphecyClosure', 'private'); | ||
|
|
||
| foreach ($node->getMethods() as $name => $method) { | ||
| if ('__construct' === strtolower($name)) { | ||
| $methodName = strtolower($name); | ||
|
|
||
| if ('__construct' === $methodName) { | ||
| continue; | ||
| } | ||
|
|
||
| if (!$method->getReturnTypeNode()->hasReturnStatement()) { | ||
| if ('__destruct' === $methodName || !$method->getReturnTypeNode()->hasReturnStatement()) { | ||
| $method->setCode( | ||
| '$this->getProphecy()->makeProphecyMethodCall(__FUNCTION__, func_get_args());' | ||
| ); |
Contributor
There was a problem hiding this comment.
This does make sense but I was wondering if the special case should be handled at the source. Digging down hasReturnTypeStatement I found its providing some convenience wrapping of BetterReflection's logic. Their issues seem closed and I'm not sure where I'd start with a PR so this is probably a logical fix for now.
Contributor
Author
There was a problem hiding this comment.
thanks for idea, need to dig it deeper
Contributor
Author
There was a problem hiding this comment.
special case should be handled at the source
exactly, PHP 8.6 constructors and destructors are symmetric: neither may return a value, so both must be proxied rather than return-typed so pushing it down will invert deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #672