Skip to content

Add throws annotation on EntityManagerInterface::flush #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add throws annotation on EntityManagerInterface::flush #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
158351b
Add throws annotation on interface
VincentLanglet Nov 8, 2023
ecba080
Fix indent
VincentLanglet Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions stubs/EntityManagerInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,20 @@ interface EntityManagerInterface extends ObjectManager
*/
public function copy($entity, $deep = false);

/**
* @template T of object
* @phpstan-param class-string<T> $className
*
* @phpstan-return ClassMetadata<T>
*/
public function getClassMetadata($className);
/**
* @return void
*
* @throws ORMException
* @throws \Doctrine\DBAL\Exception\UniqueConstraintViolationException
*/
public function flush();

/**
* @template T of object
* @phpstan-param class-string<T> $className
*
* @phpstan-return ClassMetadata<T>
*/
public function getClassMetadata($className);

}
8 changes: 8 additions & 0 deletions tests/Rules/Exceptions/data/unthrown-exception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,21 @@ class FooFacade
/** @var \Doctrine\ORM\EntityManager */
private $entityManager;

/** @var \Doctrine\ORM\EntityManagerInterface */
private $entityManagerInterface;

public function doFoo(): void
{
try {
$this->entityManager->flush();
} catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
// pass
}
try {
$this->entityManagerInterface->flush();
} catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
// pass
}
}

}