Immediate unwrap AlwaysRememberedExpr after used on NodeScopeResolver #4651
+6
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ondrejmirtes Ready to merge 👍 CI notice seems unrelated as happen on latest 2.1.x branch as well. |
Member
|
Thank you, let's try this. I'll let you know if it breaks anything later. |
Contributor
|
Thank you @ondrejmirtes 👏 |
Contributor
Author
|
Thank you @ondrejmirtes, I tested phpstan 2.1.x-dev on rector-src and it seems working ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba if this accepted, this will should reduce unnecessary tweak in rector Printer
https://github.com/rectorphp/rector-src/blob/e39c3e1250194f9eaacf34c78c8e951c84f26222/src/PhpParser/Printer/BetterStandardPrinter.php#L131-L146
This PR ensure immediate unwrap AlwaysRememberedExpr after used on NodeScopeResolver so not hide behind deep cloned node.