Return early from ClassReflection::getMethod() cache#6043
Merged
Conversation
The method wrote resolved reflections into $this->methods but never read them back, so every repeated call re-ran the whole extension dispatch (native hasMethod lookup, canCallMethod, wrapping). The result is deterministic per cache key - the key already includes the asking scope's class - so the early return preserves behaviour.
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Jul 12, 2026
staabm
referenced
this pull request
Jul 12, 2026
The method wrote resolved reflections into $this->methods but never read them back, so every repeated call re-ran the whole extension dispatch (native hasMethod lookup, canCallMethod, wrapping). The result is deterministic per cache key - the key already includes the asking scope's class - so the early return preserves behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method wrote resolved reflections into $this->methods but never read them back, so every repeated call re-ran the whole extension dispatch (native hasMethod lookup, canCallMethod, wrapping). The result is deterministic per cache key - the key already includes the asking scope's class - so the early return preserves behaviour.
this is one of the fixes from fable performance branch, but I was not able to verify it improves performance in my benchmarks.
in the end I think it is a bugfix, to make the caching work.
review with whitespaces ignored