Prevent unnecessary method calls on Type - #6076
Merged
Merged
Conversation
staabm
commented
Jul 21, 2026
| $typeWithMethod = $typeWithMethod->filterTypes(static fn (Type $innerType) => $innerType->hasMethod($methodName)->yes()); | ||
| } | ||
|
|
||
| if (!$typeWithMethod->hasMethod($methodName)->yes()) { |
Contributor
Author
There was a problem hiding this comment.
before this PR:
in case of a UnionType, this if-condition invoked ->hasMethod($methodName)->yes() again on a UnionType, which previously was filtered with ->filterTypes(static fn (Type $innerType) => $innerType->hasMethod($methodName)->yes()) - so could either contain only types which have the method $methodName, or a NeverType.
staabm
marked this pull request as ready for review
July 21, 2026 10:22
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
came here because I saw these methods showing up in profiles of tempest