Preserve maybe in BitwiseFlagHelper for bitwise-or with dynamic operands - #6080
Merged
Conversation
The BitwiseOr branch of bitwiseOrContainsConstant() returned
createFromBoolean(left->yes() || right->yes()), collapsing "maybe" to
"no". For an expression like SOME_CONST | $dynamicInt it answered a
definite "no" for a flag the dynamic operand may well contain. The
correct trinary is left->or(right): yes if either side definitely
contains the flag, no only if both sides definitely don't, maybe
otherwise.
Callers acting on ->no() were affected:
- JsonThrowTypeExtension no longer reports a false-positive
"Dead catch - JsonException" for json_encode()/json_decode() called
with JSON_X | $dynamicFlags, and correctly attributes a possible
JsonException throw type to such calls.
- PregSplitDynamicReturnTypeExtension now keeps the
array{string, int<0, max>} element shape in the return type when
PREG_SPLIT_OFFSET_CAPTURE may be present in dynamic flags.
Callers acting only on ->yes() are unaffected.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
staabm
approved these changes
Jul 21, 2026
VincentLanglet
approved these changes
Jul 21, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BitwiseOr branch of bitwiseOrContainsConstant() returned createFromBoolean(left->yes() || right->yes()), collapsing "maybe" to "no". For an expression like SOME_CONST | $dynamicInt it answered a definite "no" for a flag the dynamic operand may well contain. The correct trinary is left->or(right): yes if either side definitely contains the flag, no only if both sides definitely don't, maybe otherwise.
Callers acting on ->no() were affected:
Callers acting only on ->yes() are unaffected.