Read operand types from ExpressionResults in BinaryOp/BooleanOr/MethodCall/Match handlers - #6137
Merged
Merged
Conversation
…dCall/Match handlers Third batch: the division-by-zero operand check reads the right operand's result (its before-scope is exactly the left result's scope), the BooleanOr right-side explicit-never check matches the BooleanAnd conversion, the method call receiver reads the var result (matching the single-pass engine's shape), and the match subject is processed first and read off its result instead of a pre-processing forward read. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019wqGgaD7iqL44t1KgpJS7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third batch of converting handler
$scope->getType()reads toExpressionResultreads (independent PR on 2.2.x; follows the merged batches 1–2).BinaryOpHandler: the division-by-zero right-operand check — the right result's before-scope is exactly the left result's scope (exact equivalence).BooleanOrHandler: the right-side explicit-never check, matching the earlierBooleanAndHandlerconversion.MethodCallHandler: the call receiver reads the var result — textually converging with the single-pass engine's shape.MatchHandler: the subject is processed first and read off its result instead of a pre-processing forward read (the read still resolves against the same entry scope, now stored as the result's before-scope).Validation: full test suite green (17776 tests), self-analysis clean, code style clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_019wqGgaD7iqL44t1KgpJS7b