Use a complete version constraint in FiniteTypeSetTest's RequiresPhp attribute - #6177
Merged
VincentLanglet merged 1 commit intoAug 3, 2026
Merged
Conversation
…attribute
`#[RequiresPhp('^8.1')]` is flagged by phpstan-phpunit's
phpunit.attributeRequiresPhpVersion rule: the caret is not one of the
operators the rule accepts and `8.1` is a two-part (incomplete) version. That
makes the Infection job's initial static-analysis run fail on every PR branched
off 2.2.x. Use `>= 8.1.0`, the form used everywhere else in the test suite.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
VincentLanglet
approved these changes
Aug 3, 2026
Contributor
|
Thanks. I need to fix phpstan-phpunit because warnings changed in newer versions :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[RequiresPhp('^8.1')]inFiniteTypeSetTest(added in #6116) is flagged by phpstan-phpunit'sphpunit.attributeRequiresPhpVersionrule:^is not one of the operators the rule accepts and8.1is a two-part, incomplete version. That makes the Infection job's initial static-analysis run exit 1 ("Version requirement is incomplete"), which fails Mutation Testing on every PR branched off current 2.2.x.This uses
>= 8.1.0, the form already used everywhere else in the suite (0 other usages use the caret form). The test still runs on 8.1+ as intended.