Skip to content

Rules\LazyRegistry, Collectors\Registry: Cache extension-class-names - #6205

Merged
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:more-ext-help2
Aug 10, 2026
Merged

Rules\LazyRegistry, Collectors\Registry: Cache extension-class-names#6205
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:more-ext-help2

Conversation

@staabm

@staabm staabm commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

followup to #6203

@ondrejmirtes

Copy link
Copy Markdown
Member

Would be nice to measure in all similar PRs if it leads to performance (still makes sense to merge it for code quality).

@staabm
staabm marked this pull request as ready for review August 10, 2026 12:52
@phpstan-bot

Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@staabm

staabm commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

I don't see more improvements in measures (and I think its related because the adjusted code-sites are already cached once per node-type)

@staabm
staabm merged commit d6f211f into phpstan:2.2.x Aug 10, 2026
761 of 762 checks passed
@staabm
staabm deleted the more-ext-help2 branch August 10, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants