HashFunctionsReturnTypeExtension: init hash-algorithm list lazily - #6345
Merged
Conversation
staabm
marked this pull request as ready for review
September 2, 2026 11:04
Collaborator
|
This pull request has been marked as ready for review. |
There was a problem hiding this comment.
🟢 Approval recommended
The lazy initialization preserves existing behavior while safely avoiding unnecessary computation.
Pull request overview
Lazily initializes the supported hash algorithm list, avoiding unnecessary startup work when hash functions with constant algorithm arguments are not analyzed.
Changes:
- Makes the algorithm cache nullable.
- Populates it on first use with
hash_algos().
File summaries
| File | Description |
|---|---|
src/Type/Php/HashFunctionsReturnTypeExtension.php |
Defers hash algorithm discovery until validation is required. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need this list only when we find one of the supported hash functions with a constant 1st arg.
atm we pay the cost for listing the algos on rule creation, no matter how the analyzed code looks like.
its not that expensive (1-2ms), but its easy to prevent