Adding methods to correct dead/hot pixels in data - #36
Merged
Conversation
phrgab
marked this pull request as ready for review
May 26, 2026 16:25
shum23
requested changes
May 28, 2026
shum23
left a comment
shum23
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @phrgab. I've just suggested a couple of edits there mainly for the docstrings to make them clearer for users.
I've noticed that the docstring for correct_isolated_bad_pixels says 'up to 2x2' but the code doesn't actually check whether the bad blob passed is larger than that. Someone could in principle pass a 5x5 blob without triggering an error. Should we maybe add a ValueError guard or something to catch oversized pixels?
shum23
reviewed
May 28, 2026
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Co-authored-by: Shu <148200713+shum23@users.noreply.github.com>
Owner
Author
|
Great, thanks for the careful checks and improvements @shum23. I think all the suggestions should now be implemented, including the guarding against supplying a mask with >2x pixels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding helper methods for hot/bad-pixel correction in fixed mode and swept scans.
With associated basic unit tests.
Closes #32