moved media files from Piccolo Admin to Piccolo API

[sinisaos]

@dantownsend I hope you meant something similar to this. Once you've checked and merged this, I'll make the changes in Piccolo Admin. Related to this issue.

[codecov-commenter]

Codecov Report

Merging #168 (4621d1c) into master (33ca725) will increase coverage by 3.66%.
The diff coverage is 97.99%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   88.38%   92.04%   +3.66%     
==========================================
  Files          29       32       +3     
  Lines        1576     1761     +185     
==========================================
+ Hits         1393     1621     +228     
+ Misses        183      140      -43     

Impacted Files	Coverage Δ
piccolo_api/crud/endpoints.py	94.96% <50.00%> (-0.22%)	⬇️
piccolo_api/media/base.py	96.38% <96.38%> (ø)
piccolo_api/media/s3.py	98.88% <98.88%> (ø)
piccolo_api/media/local.py	100.00% <100.00%> (ø)
piccolo_api/crud/validators.py	93.61% <0.00%> (-0.14%)	⬇️
piccolo_api/shared/middleware/junction.py	0.00% <0.00%> (ø)
piccolo_api/jwt_auth/middleware.py	88.37% <0.00%> (+3.26%)	⬆️
piccolo_api/jwt_auth/endpoints.py	100.00% <0.00%> (+9.09%)	⬆️
piccolo_api/session_auth/endpoints.py	85.10% <0.00%> (+9.95%)	⬆️
piccolo_api/change_password/endpoints.py	96.05% <0.00%> (+10.33%)	⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dantownsend]

@sinisaos This looks great, thanks.

I think the only thing we should consider is having boto3 as an optional requirement in setup.py.

https://github.com/piccolo-orm/piccolo_admin/blob/master/setup.py

[lgtm-com]

This pull request fixes 1 alert when merging 02bc007 into 33ca725 - view on LGTM.com

fixed alerts:

• 1 for `__eq__` not overridden when adding attributes

[sinisaos]

@dantownsend I hope that's what you meant, otherwise feel free to change it.

[lgtm-com]

This pull request fixes 1 alert when merging f063e4a into 33ca725 - view on LGTM.com

fixed alerts:

• 1 for `__eq__` not overridden when adding attributes

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging c059447 into 33ca725 - view on LGTM.com

new alerts:

• 1 for Unused import

fixed alerts:

• 1 for `__eq__` not overridden when adding attributes

[sinisaos]

@dantownsend Can you please help me with these lgtm warnings?

[dantownsend]

@sinisaos I'll have a look.

[sinisaos]

@dantownsend Thanks

[lgtm-com]

This pull request fixes 1 alert when merging ab9904f into 33ca725 - view on LGTM.com

fixed alerts:

• 1 for `__eq__` not overridden when adding attributes

[lgtm-com]

This pull request fixes 1 alert when merging 4621d1c into 33ca725 - view on LGTM.com

fixed alerts:

• 1 for `__eq__` not overridden when adding attributes

[dantownsend]

@sinisaos I think it's OK. Sometimes LGTM can be annoying. Thanks for this.

[dantownsend]

@sinisaos I've published a new version of Piccolo API.

If you get a chance at any time, can you update Piccolo Admin, so it uses the latest version of Piccolo API, and imports this new code?

[sinisaos]

@dantownsend No problem. I will do it now.