Cleanup: dead IPC commands, unfinished run rows, duplicated helpers

[ElbertePlinio]

From the 2026-07-19 complementary swarm review (read-only, checked against #220 territory — no overlap).

P1 — dead-but-registered IPC + open-forever run rows

• settings_get/settings_upsert/agent_run_finish are registered but have zero call sites (src/lib/db.ts:178-181,200-206; src-tauri/src/lib.rs:308-309,318; db_commands.rs:265,273,328). Consequence: recordForgeDispatch (src/lib/runRecord.ts:51) inserts agent_run_log rows with finishedAt: null that are never finished. Decide: either call agent_run_finish in the dispatch completion path (one line) or delete all three commands + finish_agent_run (crates/pickforge-core/src/db/mod.rs:1417-1427).

P1 — performance

• LogcatView issues one IPC invoke per log line. Batch appends.

P2 — simplify

• errorText helper duplicated 13× (agentChat.ts:259, operator.ts:420, voiceDock.ts:53, orchestra.ts:238, remoteAttach.ts:33, + ~8 inline). One src/lib/errors.ts, mechanical replacement.
• waitForBootedSerial/waitForBootedSimulator are the same polling function with different predicates (src/stores/runLaunch.ts:149-181). Collapse to waitForDevice(match, epoch).
• remoteHostRevokeClient wired through IPC but no UI caller (src/lib/remoteHost.ts:73, remote_commands.rs:130, lib.rs:245) — there is currently no way to revoke a paired remote client. Decision needed: build the UI or delete the path.

Validation

• bun run build; unit tests for runLaunch/db; cargo check workspace.

[ElbertePlinio]

Progress: opened #242, implementing this issue.

• Dead IPC decision (P1): agent_run_log has no read/list command anywhere in the codebase — nothing ever surfaces its rows to the user (unlike the sibling pick_insert in the same recordForgeDispatch call, which backs the History screen). Wiring agent_run_finish in would change zero observable behavior, so I deleted the dead agent_run_finish path (TS export, Rust command, handler, finish_agent_run core fn) instead of wiring it in. settings_get/settings_upsert were confirmed dead (zero call sites, ProjectSettings type unused elsewhere) and deleted along with the type; the core get_settings/upsert_settings fns stay since the project_settings migration unit tests exercise them directly.
• LogcatView (P1): batched per-line mcp_push_log invokes + signal updates into a flush every ~75ms / 200 lines, preserving order and the ring-buffer cap.
• errorText dedup (P2): new src/lib/errors.ts, replaced the duplicates. voiceDock.ts (and hostedRouter.ts/credits.ts, found via grep) have a custom non-Error fallback message, not String(e) — kept those local wrappers, zero behavior change.
• waitForDevice (P2): collapsed waitForBootedSerial/waitForBootedSimulator into one waitForDevice(match, epoch).
• remoteHostRevokeClient (P2): flagging per the issue, not touching it. It's wired through IPC (remoteHost.ts:73, remote_commands.rs:130, lib.rs:245) with no UI caller — there's currently no way for a user to revoke a paired remote client. This needs a product decision (build the revoke-client UI, or intentionally remove the path) rather than a cleanup call, so I left the code as-is.

PR: #242