This repository was archived by the owner on Sep 4, 2026. It is now read-only.
feat(sidebar): make the work card's brief the plan's active step - #393
Merged
Conversation
wired to it, but `taskBriefText` has no writer outside fixtures, so the middle of every real card — the part that says what the agent is doing — was empty. The brief is now the plan's `inProgress` step, per the decision recorded on the issue. That needs no new plumbing: `PlanItemStatus` already carries `inProgress` and `latestPlanForChat` is the same accessor `cardPlanProgress` already reads for `plan M/N`. So the card says *step 2 of 5* in its footer and *what step 2 is* on this line, from one source — they cannot drift. `taskBriefText` becomes the fallback rather than the only source, lighting up when #210's one-liner producer lands. Resolved sub-decisions: - **Truncation**: capped in the store at 120 chars, and newlines flattened. The line is single-line-ellipsis in CSS anyway, so anything past that is invisible — a persisted value has no reason to be longer than what can be read. - **Precedence**: plan step wins over a cached one-liner, made explicit in the resolver so it cannot drift. - **All-complete plan** (M === N, no `inProgress`): falls through to the one-liner, then to nothing. Showing the last completed step would claim work that is finished. An `inProgress` step with only whitespace is ignored rather than rendered as a blank line, matching the locked no-placeholder rule. Verified in the rendered app: the fixture card showing `plan 2/5` now reads "Wire the swarm survey lanes into the footer", and the card with no plan still falls through to its one-liner. Refs #361
ElbertePlinio
force-pushed
the
feat-361-plan-brief
branch
from
July 26, 2026 03:09
3ff582e to
6c1c2e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#361 PR 2 — the issue's primary gap.
The renderer existed and
cardBriefwas wired to it, buttaskBriefTexthas no writer outside fixtures.workspace.tsalways creates chats withtaskBriefText: null; the only non-null values are VRT mocks. So the middle of every real card — the part that says what the agent is doing — was empty, and the card collapsed tomark · project · time/title · WORKING/$1.88.The brief is the plan's active step
Per the decision recorded on the issue. This needs no new plumbing:
PlanItemStatusalready carriesinProgress, andlatestPlanForChatis the same accessorcardPlanProgressalready reads forplan M/N.That is the point. The card says step 2 of 5 in its footer and what step 2 is on this line, from one source — they cannot drift apart.
taskBriefTextbecomes the fallback slot rather than the only source, lighting up when #210's one-liner producer lands.Verified in the rendered app
The card with a plan shows its actual in-progress step next to the matching tally; the card without one falls through to its one-liner. Not just asserted — read off the running app.
Sub-decisions resolved
M === N, noinProgress) → falls through to the one-liner, then to nothing. Showing the last completed step would claim work that is already finished.An
inProgressstep with only whitespace is ignored rather than rendered as a blank line, matching the locked no-placeholder rule.Tests
8 new, verified load-bearing (removing the plan-step path fails 3):
Validation
bun run test:unit— 1619 passedbunx tsc --noEmitclean;bun run lintcleanRemaining on #361
PR 3 — the model-written one-liner producer — is not here. The issue says to sequence it with #210 so one producer serves both, and building a second one here would be exactly the duplication that decision exists to prevent. The fallback slot is in place and tested for when it lands.
Refs #361