fix(stimulus-tabs): update background colors to use CSS variables for…#3073
Merged
Conversation
… theming support PIE-746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… theming support PIE-746
color.background() and color.white() compiled to var(--pie-background, rgba(255,255,255,0)) and var(--pie-white, #ffffff)
Added this new var in passage (
--pie-passage-header-background) so this way passage stays generic/reusable, and the coupling lives in exactly one place — the spot where someone makes the product decision that these two should share a color.In pie-players it can be used like this to have the same color as the card header:
https://illuminate.atlassian.net/browse/PIE-746