build(deps-dev): bump husky from 5.1.1 to 5.1.2#1250
Merged
Conversation
Bumps [husky](https://github.com/typicode/husky) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v5.1.1...v5.1.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
Code Climate has analyzed commit fec031c and detected 0 issues on this pull request. View more on Code Climate. |
PierreBrisorgueil
added a commit
that referenced
this pull request
May 31, 2026
…#1250) (#3743) * fix(billing): resolve plan via priceId map, not price.metadata.planId (#3742) Port trawl's #1250 fix upstream: `customer.subscription.updated` was reading `price.metadata.planId` which is empty in real Stripe webhook payloads (planId lives on the Product, not the Price). Every paid org's plan was silently reset to `free` on every Stripe subscription update event. Fix: - Add `buildPriceIdToPlanMap()` — builds `Map<priceId, planName>` from `config.stripe.prices` at boot (monthly + annual per plan) - Rewrite `resolvePlan()` — looks up plan via priceId map first; falls back to `price.metadata.planId` for legacy test fixtures; final fallback `free` + warn - Sync `cancelAt`/`cancelAtPeriodEnd` on `customer.subscription.updated` — writes the fields added by #3741 so the UI can show pending cancellation dates - Use priceId map in `previousPlan` detection (plan change block in updated handler) - Strip trawl-specific `analytics.capture('subscription_changed')` calls (not ported) Also ports `retryWithBackoff` + `isNonTransientStripeError` patterns (already in devkit from a prior PR — kept identical to trawl). Adds 20 unit tests covering: priceId map resolution, annual/monthly variants, unknown priceId fallback to free, legacy metadata fallback, priority of map over metadata, cancelAt unix→Date conversion, null cancel clear, absent field guard, handleSubscriptionCreated race safety (E11000 idempotency), and Dashboard subscription creation path. Closes #3742 * docs(billing): add ERRORS.md entry for price.metadata.planId empty in Stripe webhooks
PierreBrisorgueil
added a commit
that referenced
this pull request
Jun 1, 2026
…+ 4 hardening) (#3758) * fix(billing): re-apply lost C.2 review nits (warn-on-unknown-priceId + 4 hardening) 5 Copilot review findings from PR #3743 (#1250 P0) were silently lost because a controller-side fix commit was never pushed to origin before the squash-merge. Re-applied fixes: 1. JSDoc for buildPriceIdToPlanMap: accurate description with @returns tag 2. resolvePlan: warn log when priceId not in map and metadata empty (operationally critical — same silent-free-downgrade shape as the P0 it was meant to prevent) 3. cancel_at truthy check → typeof === 'number' (prevents cancel_at=0 being skipped) 4. previousPlan: validatePlan() before comparison (rejects stale/invalid metadata values) 5. Test comment: corrects misleading "retryWithBackoff setTimeout suppression" claim Refs: #3743, plan 2026-05-30-trawl-devkit-perfect-alignment.md * fix(billing): gate resolvePlan warn to metadata-absent case only Copilot review finding on PR #3758: the previous warn fired whenever priceId was present and metadata didn't validate, but the log message said "metadata empty" — misleading when metadata IS present but invalid (validatePlan already warns in that case → double-warn). Gate: only emit the warn when rawMeta is also absent (!rawMeta), and update the message from "metadata empty" to "no metadata" to be precise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps husky from 5.1.1 to 5.1.2.
Release notes
Sourced from husky's releases.
Commits
299bcf45.1.284be675docs: prepare script instead of postinstall (#890)a7cc2cedocs: use npx vs. npm exec (#886)6b626f7docs: change nvm.sh loading scripte011e76docs: rollback to npx --no-install611630ffix(init): add trailing newline8e2ce2fstyle: lint86a2a39chore: update package-lock.jsonDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: