Adding a bunch of tests to verify/validate annotations#234
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for annotation rendering functionality and refactors existing tests to use a new assertDefined helper for better type safety.
Key Changes:
- Added new test utilities in
testUtils.tsfor working with HAST elements and assertions - Created extensive annotation rendering tests covering unified/split styles, line type variations, and collapsing behavior
- Refactored existing tests to use
assertDefinedhelper instead oftoBeDefined()for improved type narrowing
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/diffs/test/testUtils.ts |
Added assertion helper (assertDefined) and HAST element helper functions for test utilities |
packages/diffs/test/annotations.test.ts |
New comprehensive test suite validating annotation rendering across different diff styles and line types |
packages/diffs/test/parseDiffFromFile.test.ts |
Refactored to use assertDefined helper for type narrowing |
packages/diffs/test/FileRenderer.test.ts |
Simplified test by removing redundant assertions and using destructuring |
packages/diffs/test/FileRenderer.ast.test.ts |
Refactored to use assertDefined and replaced toBeString() matcher |
packages/diffs/test/DiffHunksRender.test.ts |
Updated assertions to use assertDefined helper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of tests around how annotations get rendered out. It's important that the data attributes referencing line indexes match up properly depending on split vs unified as well as ensuring they get rendered into the right places