add patch options to parseDiffFromFile#250
Merged
amadeus merged 1 commit intopierrecomputer:mainfrom Dec 29, 2025
Merged
Conversation
|
@BrianHung is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
amadeus
reviewed
Dec 29, 2025
Member
amadeus
left a comment
There was a problem hiding this comment.
lgtm, thanks for the contribution!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows patch options to be passed to
parseDiffFromFile. This comes from the upstream library (https://github.com/kpdecker/jsdiff), and are exposing that as an option to downstream consumers of this diffs lib.Motivation & Context
I want to customize the context lines for grouping hunks. Default right now is 3. However, coming from CodeMirror, it uses
context = 1(https://github.com/codemirror/merge/blob/main/src/chunk.ts), so I would like this customizability for compatibility there.Type of changes
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)Related issues