Fix a scroll fix if container grows#627
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dae2671ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly
amadeus
force-pushed
the
amadeus/scroll-fix-bug
branch
from
8dae267 to
ceaeff4
Compare
amadeus
added a commit
that referenced
this pull request
May 2, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 7, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 8, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 8, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 12, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
amadeus
added a commit
that referenced
this pull request
May 16, 2026
* Add scroll anchor regression test * Fix a scroll fix if container grows in certain cases when re-computing scroll position for an anchor, we'd need to move to a scroll position that's not yet valid, and therefore the pre-mutate position fix would fail because the scroll position would get inherently clamped. Now we adjust the height of the scroll region first, then pre-scroll fix, then mutate/render to ensure it works properly * pr review fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scroll fixing due to option changes (like when changing diffStyle for example), the height of the scroll region could dramatically change. We had an optimization where we do the scroll fix prior to applying the new dom structure to help coalesce mutations together and not trigger unnecessary reflows. However, if the new adjusted scroll position was outside the bounds of the current window, then the scroll fix would ultimately get clamped and we wouldn't be in the right spot for the new dom that would then adjust the height of the scroll view.
Essentially the fix here is to first sync the new container height, then apply the early scroll fix so it doesn't get clamped.
I also realized we don't disable browser scroll anchoring on our root by default, and that's something that's very important and we should apply it and not depend on the user space applying this.