DiffsHub API Improvements#636
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/diffshub-api-improvements
branch
from
53a82ab to
e115f67
Compare
amadeus
force-pushed
the
amadeus/diffshub-api-improvements
branch
from
f6631d6 to
1bd19f1
Compare
amadeus
force-pushed
the
amadeus/diffshub-api-improvements
branch
from
1bd19f1 to
3b6a8f3
Compare
amadeus
force-pushed
the
amadeus/diffshub-api-improvements
branch
from
a43810e to
7477a29
Compare
Member
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11f23380da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Don't allow the diffs to render if the worker pool is not initialized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking the API to use
.diffover.patch(this will enable you to view any /compare or /commit urls as well.Also it'll make the trees interface a lot cleaner since it won't always need to show separate commits.
Reworked diff/patch loading to be streamed so stuff can start showing earlier. This also inspired a new React API that's more imperative which will work a lot better in situations where we are rendering a ton of data.
I also vibe-slopped a stats item for the PR that will need some love from @mdo
NOTE: converted the larg.patch file to be a
.diffstyle file so it doesn't include a bunch of commits