Conversation
mdo
commented
May 7, 2026
mdo
commented
- New sidebar comment list
- New form and comment design
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a64f15761a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (parsedURL.pathname === '/') { | ||
| return undefined; | ||
| } | ||
|
|
||
| return `/${owner}/${repo}/pull/${pullFile}`; | ||
| return parsedURL.pathname; |
There was a problem hiding this comment.
getGitHubPath now accepts any non-root GitHub pathname, but the viewer route only exists at /{owner}/{repo}/{...githubPath}. Inputs like https://github.com/nodejs or https://github.com/nodejs/node therefore pass validation and trigger router.push(...), which lands users on a Next.js 404 instead of showing the in-app diff error state. Tighten validation to require at least owner/repo plus a trailing diff target segment before returning a path.
Useful? React with 👍 / 👎.
amadeus
left a comment
amadeus
left a comment
There was a problem hiding this comment.
Lookin sharp! Mostly just a types question that doesn't really matter but is just me on my bullshit, can ignore if you want
* Restyle comment form and comment * better comments and comment lists * border tweak * Avatars coming at you * Review feedback * update apple icons while here
* Restyle comment form and comment * better comments and comment lists * border tweak * Avatars coming at you * Review feedback * update apple icons while here
* Restyle comment form and comment * better comments and comment lists * border tweak * Avatars coming at you * Review feedback * update apple icons while here
* Restyle comment form and comment * better comments and comment lists * border tweak * Avatars coming at you * Review feedback * update apple icons while here
2 participants
