Skip to content

Update OG images and icons#656

Merged
mdo merged 1 commit into
beta-1.2from
mdo/diffshub-og-v2
May 7, 2026
Merged

Update OG images and icons#656
mdo merged 1 commit into
beta-1.2from
mdo/diffshub-og-v2

Conversation

@mdo
Copy link
Copy Markdown
Contributor

@mdo mdo commented May 7, 2026

Forgot to push this into #648.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffshub Ready Ready Preview May 7, 2026 9:08pm
pierre-docs-trees Ready Ready Preview May 7, 2026 9:08pm
pierrejs-diff-demo Ready Ready Preview May 7, 2026 9:08pm
pierrejs-docs Ready Ready Preview May 7, 2026 9:08pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/pierrecomputer/pierre/blob/4a0e811982becae5aaded8c2260480cf3e7cbd0f/apps/docs/public/diffshub-brand/icon.png#L1
P2 Badge Keep referenced diffshub PNG favicon in public assets

Removing apps/docs/public/diffshub-brand/icon.png introduces a broken metadata asset because the diffshub site still declares '/diffshub-brand/icon.png' in SITE_ICONS_BY_SITE.diffshub (apps/docs/app/layout.tsx, around line 136). In environments serving this metadata, clients requesting that icon now get a 404, so the favicon/icon set is incomplete unless the reference is updated to the new .ico file or the PNG is restored.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdo mdo merged commit f8c050b into beta-1.2 May 7, 2026
12 checks passed
@mdo mdo deleted the mdo/diffshub-og-v2 branch May 7, 2026 21:10
amadeus pushed a commit that referenced this pull request May 8, 2026
amadeus pushed a commit that referenced this pull request May 8, 2026
amadeus pushed a commit that referenced this pull request May 9, 2026
amadeus pushed a commit that referenced this pull request May 9, 2026
amadeus pushed a commit that referenced this pull request May 9, 2026
amadeus pushed a commit that referenced this pull request May 12, 2026
amadeus pushed a commit that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant