Update OG images and icons#656
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
https://github.com/pierrecomputer/pierre/blob/4a0e811982becae5aaded8c2260480cf3e7cbd0f/apps/docs/public/diffshub-brand/icon.png#L1
Keep referenced diffshub PNG favicon in public assets
Removing apps/docs/public/diffshub-brand/icon.png introduces a broken metadata asset because the diffshub site still declares '/diffshub-brand/icon.png' in SITE_ICONS_BY_SITE.diffshub (apps/docs/app/layout.tsx, around line 136). In environments serving this metadata, clients requesting that icon now get a 404, so the favicon/icon set is incomplete unless the reference is updated to the new .ico file or the PNG is restored.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Forgot to push this into #648.