More polish, including scrollbar sizing fixes#658
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
changed the title
amadeus
force-pushed
the
amadeus/scroll-gutter-size
branch
from
e2bc2c0 to
8b99585
Compare
Measure scrollbar gutter size at runtime so the code view can compensate for platform-specific scrollbar widths, and refresh the diffs hub scrollbar styling. Tighten sidebar/file-tree spacing, mobile overlay layout, loading spinner treatment, and code view borders for a more consistent review UI.
amadeus
force-pushed
the
amadeus/scroll-gutter-size
branch
from
8b99585 to
e725035
Compare
* Add a border for the scrollbar to feel better * Remove top margin from the scrollbar
This should polish a ton of things around where mobile felt a bit more jank
amadeus
force-pushed
the
amadeus/scroll-gutter-size
branch
from
68f2800 to
84283fb
Compare
Member
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP