[diffs] CodeView item metrics validation#665
Merged
Merged
Conversation
* Also renamed viewerMetrics to layout (since it differs from itemMetrics intent) * Also improved docs around explaining this
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 904b69f071
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
added a commit
that referenced
this pull request
May 12, 2026
Add a feature to help validate itemMetrics * Also renamed viewerMetrics to layout (since it differs from itemMetrics intent) * Also improved docs around explaining this
amadeus
added a commit
that referenced
this pull request
May 16, 2026
Add a feature to help validate itemMetrics * Also renamed viewerMetrics to layout (since it differs from itemMetrics intent) * Also improved docs around explaining this
amadeus
added a commit
that referenced
this pull request
May 20, 2026
Add a feature to help validate itemMetrics * Also renamed viewerMetrics to layout (since it differs from itemMetrics intent) * Also improved docs around explaining this
amadeus
added a commit
that referenced
this pull request
May 20, 2026
Add a feature to help validate itemMetrics * Also renamed viewerMetrics to layout (since it differs from itemMetrics intent) * Also improved docs around explaining this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since valid item metrics are so important, I've added a new prop to help validate any use of custom CSS, a prop that runs only in dev mode the validate this logic.
Additionally this got me thinking that
viewerMetricswas not a good name for this prop as it really actually controlled layout things (like paddings and gap) and to be named similarly to itemMetrics was confusing (since itemMetrics should ONLY be used with unsafeCSS and doesn't actually control the values specfied).Also added and updated docs as necessary.