Skip to content

Stupid but harmless memory cleanup in workers #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amadeus merged 1 commit into from
May 16, 2026
+6 −0
Merged

Stupid but harmless memory cleanup in workers #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/diffs/src/worker/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ let renderOptions: WorkerRenderingOptions = {
maxLineDiffLength: 1000,
};

const EMPTY_REGEXP = /(?:)/;

self.addEventListener('error', (event) => {
console.error('[Shiki Worker] Unhandled error:', event.error);
});
Expand Down Expand Up @@ -71,6 +73,10 @@ async function handleMessage(request: WorkerRequest) {
} catch (error) {
console.error('Worker error:', error);
sendError(request.id, error);
} finally {
// Reset legacy RegExp last-match state so it cannot keep a highlighted
// source string alive after a highlight job completes.
EMPTY_REGEXP.exec('');
}
}

Expand Down
Loading