[diffs] tolerate stale IntersectionObserver entries after disconnect#697
Merged
Conversation
IntersectionObserver delivers entries asynchronously, so the callback can fire for a target the Virtualizer has already released via disconnect() or releaseElement() — at which point the target is no longer in this.observers and the previous code threw. Replace the throw with continue so stale entries are ignored. The target-not-HTMLElement throw above is left as-is since real browsers won't deliver non-Element targets.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
approved these changes
May 18, 2026
amadeus
pushed a commit
that referenced
this pull request
May 20, 2026
…697) IntersectionObserver delivers entries asynchronously, so the callback can fire for a target the Virtualizer has already released via disconnect() or releaseElement() — at which point the target is no longer in this.observers and the previous code threw. Replace the throw with continue so stale entries are ignored. The target-not-HTMLElement throw above is left as-is since real browsers won't deliver non-Element targets.
amadeus
pushed a commit
that referenced
this pull request
May 20, 2026
…697) IntersectionObserver delivers entries asynchronously, so the callback can fire for a target the Virtualizer has already released via disconnect() or releaseElement() — at which point the target is no longer in this.observers and the previous code threw. Replace the throw with continue so stale entries are ignored. The target-not-HTMLElement throw above is left as-is since real browsers won't deliver non-Element targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntersectionObserver delivers entries asynchronously, so the callback can fire for a target the Virtualizer has already released via disconnect() or releaseElement() — at which point the target is no longer in this.observers and the previous code threw.
Replace the throw with continue so stale entries are ignored. The target-not-HTMLElement throw above is left as-is since real browsers won't deliver non-Element targets.