[diffshub] rewrite PR-scoped commit URLs to /commit/{sha}#703
Merged
Conversation
Map `/owner/repo/pull/N/(changes|files)/{sha}` to `/owner/repo/commit/{sha}`
so a GitHub PR URL scoped to a specific commit resolves to the standalone
commit view, which is the only form the diff loader can fetch.
The rewrite runs in two places:
- `normalizeGitHubPath` covers form input via `getPatchViewerHref`.
- The catch-all viewer route now redirects to the canonical path when
someone navigates directly, fixing the "couldn't load the diff" failure
on pasted URLs.
Extracts `resolveDiffshubViewerRoute` from the route page so the
redirect/render decision is unit-testable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
pushed a commit
that referenced
this pull request
May 20, 2026
Map `/owner/repo/pull/N/(changes|files)/{sha}` to `/owner/repo/commit/{sha}`
so a GitHub PR URL scoped to a specific commit resolves to the standalone
commit view, which is the only form the diff loader can fetch.
The rewrite runs in two places:
- `normalizeGitHubPath` covers form input via `getPatchViewerHref`.
- The catch-all viewer route now redirects to the canonical path when
someone navigates directly, fixing the "couldn't load the diff" failure
on pasted URLs.
Extracts `resolveDiffshubViewerRoute` from the route page so the
redirect/render decision is unit-testable.
amadeus
pushed a commit
that referenced
this pull request
May 20, 2026
Map `/owner/repo/pull/N/(changes|files)/{sha}` to `/owner/repo/commit/{sha}`
so a GitHub PR URL scoped to a specific commit resolves to the standalone
commit view, which is the only form the diff loader can fetch.
The rewrite runs in two places:
- `normalizeGitHubPath` covers form input via `getPatchViewerHref`.
- The catch-all viewer route now redirects to the canonical path when
someone navigates directly, fixing the "couldn't load the diff" failure
on pasted URLs.
Extracts `resolveDiffshubViewerRoute` from the route page so the
redirect/render decision is unit-testable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map
/owner/repo/pull/N/(changes|files)/{sha}to/owner/repo/commit/{sha}so a GitHub PR URL scoped to a specific commit resolves to the standalone commit view, which is the only form the diff loader can fetch.The rewrite runs in two places:
normalizeGitHubPathcovers form input viagetPatchViewerHref.Extracts
resolveDiffshubViewerRoutefrom the route page so the redirect/render decision is unit-testable.Example of successful mapping (and redirect):
https://pierre-docs-diffshub-git-nicolas-4fb69f-pierre-computer-company.vercel.app/pierrecomputer/pierre/pull/692/changes/3bbb3d55da7bbc1b290e1c4c0c5430016ec4d0cf