fix(diffs): handle quoted git diff headers#736
Merged
Conversation
Git can emit quoted diff headers for escaped non-ASCII paths, such as `diff --git "a/..." "b/..."`. The parser regex accepted this form, but the capture destructuring only read the unquoted capture slots, causing `name` to be undefined and crashing on `.trim()`. Select the quoted or unquoted capture groups explicitly, fail softly for invalid git diff headers, and add regression coverage for quoted escaped file names.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git can emit quoted diff headers for escaped non-ASCII paths, such as
diff --git "a/..." "b/...". The parser regex accepted this form, but the capture destructuring only read the unquoted capture slots, causingnameto be undefined and crashing on.trim().Select the quoted or unquoted capture groups explicitly, fail softly for invalid git diff headers, and add regression coverage for quoted escaped file names.
A bug that was exposed by this PR: vercel/next.js#93247