refactor(editor): Reshape search panel UI#764
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the editor’s styling and icon rendering by moving editor CSS into a dedicated stylesheet and introducing an SVG sprite-based icon system used by editor widgets.
Changes:
- Replaced inline
editorCSSstring withstyle.cssand updated the editor to load it. - Added an editor-local SVG sprite sheet (
sprite.ts) and switched Search/Quick Edit widgets to use it. - Updated theme CSS variable names for match highlighting.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/diffs/src/editor/tokenzier.ts | Updates injected theme CSS variable names for match highlighting and cursor color. |
| packages/diffs/src/editor/style.css | Introduces externalized editor/widget CSS previously embedded in TS. |
| packages/diffs/src/editor/sprite.ts | Adds SVG sprite sheet + helper for generating icon SVG markup. |
| packages/diffs/src/editor/searchPanel.ts | Replaces inline SVG strings with sprite-based icons. |
| packages/diffs/src/editor/quickEdit.ts | Replaces inline SVG string with sprite-based icon. |
| packages/diffs/src/editor/editor.ts | Loads style.css, injects sprite sheet into Shadow DOM, and removes old css.ts usage. |
| packages/diffs/src/editor/css.ts | Removes legacy embedded CSS constants (migrated to style.css). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ije
changed the title
ije
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
style.cssandsprite.tsis independent from diffs global style and sprite for lazy importing.