Skip to content

comment ui#81

Merged
fat merged 5 commits intomainfrom
fat/comments-ui
Oct 22, 2025
Merged

comment ui#81
fat merged 5 commits intomainfrom
fat/comments-ui

Conversation

@fat
Copy link
Copy Markdown
Contributor

@fat fat commented Oct 21, 2025

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2025

Someone is attempting to deploy this pull request to the Pierre Computer Company Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

Copy link
Copy Markdown
Member

@amadeus amadeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good incentive for me to make this API easier to work with 🤔

Comment thread apps/docs/app/diff-examples/Annotations.tsx Outdated
Comment thread apps/docs/app/diff-examples/Annotations.tsx Outdated
const [hoveredLineKey, setHoveredLineKey] = useState<LineKey | null>(null);
const containerRef = useRef<HTMLDivElement>(null);

const handleLineEnter = useCallback((props: any) => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have some ideas for this, but haven't gotten around to it. I think ideally it would be some API like renderMouseOverDecoration or something, and you'd just get a render function to render a component like a button, and in that render function you'd get an object of the line number and side. and so then automatically on mouse over we'd call that render function and render that wee lad

spriteSVG: SVGElement | undefined;
private eventListenersAttached = false;

private attachEventListeners() {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this wouldn't be necessary, I might have to poke around and fix this

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
pierrejs-diff-demo Ready Ready Preview Oct 21, 2025 11:06pm
pierrejs-docs Ready Ready Preview Oct 21, 2025 11:06pm

@fat fat merged commit 69858fa into main Oct 22, 2025
2 checks passed
@fat fat deleted the fat/comments-ui branch October 22, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants