Skip to content

fix(diffs): Pluralize the "0 unmodified lines" hunk label#850

Merged
necolas merged 1 commit into
mainfrom
nicolas/pluralize-modified-lines-text
Jun 19, 2026
Merged

fix(diffs): Pluralize the "0 unmodified lines" hunk label#850
necolas merged 1 commit into
mainfrom
nicolas/pluralize-modified-lines-text

Conversation

@necolas

@necolas necolas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

A collapsed hunk separator shows how many unchanged lines are hidden. When that count was zero, the label read "0 unmodified line" instead of "0 unmodified lines".

The suffix added an "s" only when the count was greater than one, so zero fell through to the singular form. Select the form with the platform's English plural rules, which treat every count other than one as plural.

A collapsed hunk separator shows how many unchanged lines are
hidden. When that count was zero, the label read "0 unmodified
line" instead of "0 unmodified lines".

The suffix added an "s" only when the count was greater than one,
so zero fell through to the singular form. Select the form with
the platform's English plural rules, which treat every count
other than one as plural.
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jun 19, 2026 4:20am
pierre-docs-diffshub Ready Ready Preview Jun 19, 2026 4:20am
pierre-docs-trees Ready Ready Preview Jun 19, 2026 4:20am
pierrejs-diff-demo Ready Ready Preview Jun 19, 2026 4:20am

Request Review

@SlexAxton SlexAxton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yea

@necolas necolas merged commit 934f013 into main Jun 19, 2026
8 checks passed
@necolas necolas deleted the nicolas/pluralize-modified-lines-text branch June 19, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants