Replacing unzer with Paypal SDK #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l SDK do not provide any message
jdreesen
reviewed
Jan 24, 2022
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
minor clean up added a redirection when trying to access the checkout page with an empty cart rollback unzer additional field, they are never used (eventual todo: remove the field there and in the dump) added sample login credentials for paypal sandbox (depends on the API keys)
dvesh3
suggested changes
Jan 27, 2022
Contributor
dvesh3
left a comment
dvesh3
left a comment
There was a problem hiding this comment.
- Sandbox details needs to be updated
paypal_client_id&paypal_secret_idenv vars missing
kingjia90
commented
Jan 27, 2022
Merged
dvesh3
approved these changes
Feb 21, 2022
dvesh3
added a commit
that referenced
this pull request
Nov 16, 2022
* Replacing unzer with Paypal SDK (#285) * works but have an issue, more details on pimcore/demo##279 * minor tweaks and changed the error message to a generic one, as paypal SDK do not provide any message * fixes typo Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> * Update composer.json * Update composer.json * added extensions and object brick minor clean up added a redirection when trying to access the checkout page with an empty cart rollback unzer additional field, they are never used (eventual todo: remove the field there and in the dump) added sample login credentials for paypal sandbox (depends on the API keys) * [PaypalSmartButton] Integrate payment provider - data dump * review changes Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> Co-authored-by: dpahuja <divesh.pahuja@pimcore.com> * revert unnecessary changes Co-authored-by: JiaJia <kingjia90@gmail.com> Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #279 (NB: check the details about "PayPalSmartButton" change)