Skip to content

[Workflows] Fix object not unpublished with force_unpublished option#9028

Merged
dvesh3 merged 2 commits intopimcore:6.9from
ergosarapu:6.9
May 7, 2021
Merged

[Workflows] Fix object not unpublished with force_unpublished option#9028
dvesh3 merged 2 commits intopimcore:6.9from
ergosarapu:6.9

Conversation

@ergosarapu
Copy link
Contributor

Changes in this pull request

Resolves #7586

Additional info

[Fix] Call element saveVersion() when workflow option save_version is set, otherwise call element save(). This allows element to unpublish when force_unpublished option is set.

@brusch brusch added this to the 6.9.4 milestone May 6, 2021
@brusch brusch added the Bug label May 6, 2021
@dvesh3
Copy link
Contributor

dvesh3 commented May 6, 2021

@ergosarapu thanks a lot for the fix. We need to add upgrade notes for the behavior change, even though this fixes the wrong behavior of force_unpublished option.

Could you please add this line to upgrade notes? "[Workflows] Fixed wrong behavior of force_unpublished option, which created a new version(in case of published) instead of unpublishing the object. If you still want to save version, just use save_version option."

@dvesh3 dvesh3 merged commit 1df0fe1 into pimcore:6.9 May 7, 2021
@dvesh3
Copy link
Contributor

dvesh3 commented May 7, 2021

@ergosarapu thanks!

@ergosarapu
Copy link
Contributor Author

Thanks for quick replies and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants