[Workflows] Fix object not unpublished with force_unpublished option#9028
Merged
dvesh3 merged 2 commits intopimcore:6.9from May 7, 2021
ergosarapu:6.9
Merged
[Workflows] Fix object not unpublished with force_unpublished option#9028dvesh3 merged 2 commits intopimcore:6.9from ergosarapu:6.9
dvesh3 merged 2 commits intopimcore:6.9from
ergosarapu:6.9
Conversation
Contributor
|
@ergosarapu thanks a lot for the fix. We need to add upgrade notes for the behavior change, even though this fixes the wrong behavior of Could you please add this line to upgrade notes? "[Workflows] Fixed wrong behavior of |
Contributor
|
@ergosarapu thanks! |
Contributor
Author
|
Thanks for quick replies and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #7586
Additional info
[Fix] Call element
saveVersion()when workflow optionsave_versionis set, otherwise call elementsave(). This allows element to unpublish whenforce_unpublishedoption is set.