Skip to content

Conversation

@iohe
Copy link
Contributor

@iohe iohe commented Aug 1, 2020

Hi Team,
there is one element missing from compensate_humidity, even if in my bme280 sensor from Enviro+ this value is always 1.0:
var5 = (1.0 + (((double)calib_data->dig_h3) / 67108864.0) * var1);

This PR adds above element and aligns algo with implementation from 
https://github.com/BoschSensortec/BME280_driver/blob/master/bme280.c#L1238

Feel free to add or not this PR :)

Thank you!

@Gadgetoid
Copy link
Member

Thank you for taking the time to PR this. I have totally failed to understand the difference, but I have added a humidity test into our test suite and your change passes- so I'll give it a shot!

@Gadgetoid Gadgetoid merged commit 963df1d into pimoroni:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants