Ensure set_gas_heater_temperature calls _set_regs with int#1
Merged
Gadgetoid merged 1 commit intopimoroni:masterfrom Oct 18, 2017
davea:patch-1
Merged
Ensure set_gas_heater_temperature calls _set_regs with int#1Gadgetoid merged 1 commit intopimoroni:masterfrom davea:patch-1
Gadgetoid merged 1 commit intopimoroni:masterfrom
davea:patch-1
Conversation
When running the `examples/read-all.py` script I was seeing a crash because
the value passed to `write_i2c_block_data` wasn't being converted to an int:
```
File "/home/pi/tmp/bme680/library/bme680/__init__.py", line 281, in _set_regs
self._i2c.write_i2c_block_data(self.i2c_addr, register, value)
TypeError: Third argument must be a list of at least one, but not more than 32 integers
```
This commit ensures `set_gas_heater_temperature` converts the temperature to an int
before it's passed to `self._set_regs`.
Member
|
Drat! Good catch, thank you! I need to watch out for any other instances of this. Although heater duration doesn't share the issue. I'll have to put out a new release of this today. |
Contributor
Author
|
Happy to help, thanks for the cool stuff you folks put out! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the
examples/read-all.pyscript I was seeing a crash becausethe value passed to
write_i2c_block_datawasn't being converted to an int:This commit ensures
set_gas_heater_temperatureconverts the temperature to an intbefore it's passed to
self._set_regs.