Add human readable IAQ scores#2
Closed
Conversation
From table 4, page 9 of the BME680 datasheet, I've added in the AQ classification (good, average, etc), tidied up the formatting of the output and made a couple of extremely trivial pylint fixups. My coding skills are still pretty basic and there is probably a much more efficient way to do this, so feel free to reject this if it's unsuitable.
Author
|
Never mind. I took the air quality reading to be a reflection of the IAQ scale in the datasheet rather than a percentage. As an aside, is it worth adding a percent symbol after the air quality output, and maybe something to indicate if a low or high percentage is good? |
ghost
closed this
ghost
deleted the
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From table 4, page 9 of the BME680 datasheet, I've added in the AQ classification (good, average, etc), tidied up the formatting of the output and made a couple of extremely trivial pylint fixups. My coding skills are still pretty basic and there is probably a much more efficient way to do this, so feel free to reject this if it's unsuitable.