Skip to content

Conversation

@kklimek
Copy link

@kklimek kklimek commented Oct 1, 2019

No description provided.

@Gadgetoid
Copy link
Member

The use of "f" string formatting is failing in both Python 2.7 and 3.5. You should swap this with "".format(), but otherwise this looks good! Thanks for raising a PR.

@coveralls
Copy link

coveralls commented Oct 2, 2019

Pull Request Test Coverage Report for Build 28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 97.642%

Files with Coverage Reduction New Missed Lines %
i2cdevice/init.py 2 97.33%
Totals Coverage Status
Change from base Build 25: -0.9%
Covered Lines: 207
Relevant Lines: 212

💛 - Coveralls

@Gadgetoid Gadgetoid merged commit 66347de into pimoroni:master Oct 5, 2019
@Gadgetoid
Copy link
Member

Thank you! I'll add a test for this error case to stop Coveralls from complaining.

@Gadgetoid
Copy link
Member

I wonder if this is worth adding to KeyError and IndexError too since it would make uncaught exceptions in i2cdevice a little more useful to end-users. 🤔

Gadgetoid added a commit that referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants