Add configurable backtest warmup#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--warmup-barsto fetch and retain user-selected pre-start OHLCV historytrade_start_time_msthrough local Docker, FastAPI, and direct-library runtimesWhy
The backtest harness previously conflated the data window with the trading window. Filtering output trades after execution could not undo pre-window positions or stateful trade counters, which caused the corpus moderate/weak results. The release runtime already supports suppressing order commands before a boundary; this PR exposes that boundary and lets users choose the preceding warmup length.
User impact
Users can now pass
--warmup-bars N. Those bars initialize indicators, higher-timeframe feeds, and Pine state, while order execution remains disabled until--start. The default remains zero for backward compatibility.Validation
ruff check src testsruff format --check src testsmypy srcpytest— 86 passed, 2 optional Docker tests skippedpineforge-release:0.1.12container run confirmed the configuredtrade_start_msin runtime provenance